rename relations for SysML compatibility#446
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
masc2023
left a comment
There was a problem hiding this comment.
Not sure why you want to change it, but before you can change something, you need to apply change request, as this is defined here
https://eclipse-score.github.io/process_description/main/general_concepts/score_building_blocks_concept.html#building-blocks-meta-model
|
We can't just change something big like that. A lot of the documentations are already build with these namings in mind, and now changing them without any reasoning or agreeing inside S-CORE that this needs to happen does not seem smart nor ideal to me. As @masc2023 said above, if this truly is a change needed, please make sure you discuss it in the correct meetings inside S-CORE and make a change request. As it's still on draft I won't close this. But as is currently this will not be considered. |
|
This change is related to eclipse-score/process_description#418 - which exists and is approved by the process_community since some time, but never got the capacity to do. |
dd364de to
9763c60
Compare
Then alright, seems reasonable. I will review it once it is not in draft anymore. |
9763c60 to
5896de3
Compare
|
@RSingh1511 this PR has some merge conflicts. |
5896de3 to
1352ab7
Compare
Done. |
|
There is still some conflicts in requirements.rst as well as the issue with the process that Roland mentioned. |
Again some concerns, the issues says compatibility to SysML, can we already target SyML 2.0, but would that not mean rather using "refine" as derived_from. |
9ce6d30 to
beb6806
Compare
|
The created documentation from the pull request is available at: docu-html |
aschemmel-tech
left a comment
There was a problem hiding this comment.
Please check my comment above and inline comments for the necessary changes. Not implemented currently is the change belongs_to -> satisfied_by
|
If you are changing requirements you |
eb3dd0d to
790e0a2
Compare
790e0a2 to
3b22afa
Compare
aschemmel-tech
left a comment
There was a problem hiding this comment.
Looks good, two minor comments inline
1c570a7 to
3b4398b
Compare
3b4398b to
be70da8
Compare
be70da8 to
954968a
Compare
aschemmel-tech
left a comment
There was a problem hiding this comment.
my comments resolved
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
Some questions, and please do not change bazel_deps without reason.
| bazel_dep(name = "rules_python", version = "2.0.2") | ||
|
|
||
| # sphinxdocs was extracted into a separate BCR module starting with rules_python 2.0.0 | ||
| bazel_dep(name = "sphinxdocs", version = "2.0.2") |
There was a problem hiding this comment.
Please do not update bazel dependencies if not absolutely needed for your PR.
| # (?:, version = ["'][^"']+["'])? — optional version argument, any value | ||
| # \) — closing paren | ||
| _BAZEL_DEP_PATTERN = r"""^bazel_dep\(name = ["']score_docs_as_code["'](?:, version = ["'][^"']+["'])?\)""" | ||
| _BAZEL_DEP_PATTERN = r"""^bazel_dep\(name = ["']score_docs_as_code["'][^)]*\)""" |
There was a problem hiding this comment.
Why is this suddenly changed?
|
As a follow up please make a PR that 'hard' deprecates the satisfies that is 'allowed' in this PR. |
| satisfies: | ||
| incoming: satisfied by | ||
| outgoing: satisfies |
There was a problem hiding this comment.
Should be deprecated in a new PR after this one
There was a problem hiding this comment.
Agreed — tracked in follow-up issue #594
|
@RSingh1511 After this is merged, can you provide a PR which removes all the deprecated options? |
Done — added a TODO |
📌 Description
🚨 Impact Analysis
✅ Checklist